Partitioned heat conduction (G+Smo participant)#604
Partitioned heat conduction (G+Smo participant)#604Crazy-Rich-Meghan wants to merge 13 commits intoprecice:developfrom
Conversation
|
Let's first iterate on #603 and then here, OK? |
|
@Crazy-Rich-Meghan do you plan to continue this development? It seems to currently be in draft state. We are happy to help get it in a good state! |
|
Hi everyone, Sorry for the delay! I have updated the partitioned heat conduction example from our side, this version supports the direct mesh access feature. To run the benchmark you need to do the following: Let me know if you get stuck somewhere! |
|
thanks for the updates! I am now trying to build on my system, based on the stable branch (Commit ef4c754785cf4949d3a89b916eed807b74b97a9b, October 2). I do get a building error, though ( By the way, I edited your instructions above to add a number next to the |
There was a problem hiding this comment.
These should be handled by clean_precice_logs(), called by clean_gismo() (see https://github.com/precice/tutorials/blob/develop/tools/cleaning-tools.sh)
There was a problem hiding this comment.
This is a bit too intrusive (especially for the .txt files). Better do a fine-grained extension of clean_gismo().
Same in the neumann-gismo directory.
There was a problem hiding this comment.
Could we move most of this content to the adapter documentation, and refer to that?
The path ./gismo_executable/gismo_executable is assumed by the run.sh, so it should probably be documented here. But we should better call that directory solver-gismo.
There was a problem hiding this comment.
Not yet referred to from the README.md. In principle, both FEniCS and G+Smo should give the same solution. If not, we should add the picture in the README.md together with a comment.
Co-authored-by: Gerasimos Chourdakis <gerasimos.chourdakis@ipvs.uni-stuttgart.de>
Co-authored-by: Gerasimos Chourdakis <gerasimos.chourdakis@ipvs.uni-stuttgart.de>
Hi @makis, have you pulled the main Gismo? We couldn't replicate the issue (on both MacOS and Ubuntu). |
MakisH
left a comment
There was a problem hiding this comment.
@Crazy-Rich-Meghan I have not forgotten about this PR, and I see there are still some easy points to close. I added a log file with my building issue.
There was a problem hiding this comment.
Do we need other modules for this tutorial? If not, let's remove. If yes, document.
But as I wrote in another comment, this looks like something to move to the adapter documentation.
|
Hi @MakisH, The rm -rf optional/gsPreCICE
cmake .. -DGISMO_OPTIONAL="gsPreCICE" |
|
Thanks, @Crazy-Rich-Meghan, this worked! The If you have no objections, I will (later) push a few changes directly to this branch, to make the tutorial more consistent with https://precice.org/tutorials-perpendicular-flap-stress.html |
|
Hi @MakisH, Thanks for the review! I've addressed your comments:
Please let me know if there's anything else that needs to be changed. |
Summary: Partitioned heat conduction G+Smo (IsoGeometric Analysis) participant
NOTE: G+Smo adapter is a submodule of the G+Smo library, to run the tutorial you need to configure G+Smo main library.
This PR is marked as a draft because the documentation for the G+Smo adapter requires updates.